-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Components: Fix placeholder color inconsistency across SearchControl
, TextControl
, Inputcontrol
#68807
base: trunk
Are you sure you want to change the base?
Components: Fix placeholder color inconsistency across SearchControl
, TextControl
, Inputcontrol
#68807
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.
To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Hey @Mamaduka, Whenever you have a moment, could you please review my PR? I’d really appreciate it. |
Thanks for working on this, @im3dabasia! Do you mind adding before/after screenshots? You can find examples here - #64586. |
There's now a smaller PR #69334 for the InputControl. My fault, I missed this PR and the associated issue #64666.
|
Closes: #64666
What?
This PR ensures a consistent placeholder color across the
InputControl
,SearchControl
, andTextControl
components by defining the color explicitly.Why?
To address the issue where placeholder color varied depending on the applied styles.
How?
The placeholder color has been defined at the component level to avoid inconsistencies and improve accessibility.
Testing Instructions
InputControl
,SearchControl
, andTextControl
components in the storybook#1e1e1e9e
(dark gray 62% opacity)#ffffff
(white)#1e1e1e9e
(dark gray 62% opacity)#f0f0f0
(light gray)#1e1e1e9e
(dark gray 62% opacity)#ffffff
(white)Screenshots
SearchControl
TextControl
InputControl