Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A11y: Remove Tooltip usage to prevent unexpected tab stops #68594

Open
wants to merge 2 commits into
base: trunk
Choose a base branch
from
Open

A11y: Remove Tooltip usage to prevent unexpected tab stops #68594

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5817076
Refactor Tooltip component usage in BoxInputControls for improved rea…
yogeshbhutkar Jan 10, 2025
641649e
Refactor: Remove Tooltip component for better a11y
yogeshbhutkar Jan 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 15 additions & 17 deletions packages/block-editor/src/components/border-radius-control/input-controls.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@
import {
__experimentalParseQuantityAndUnitFromRawValue as parseQuantityAndUnitFromRawValue,
__experimentalUnitControl as UnitControl,
Tooltip,
} from '@wordpress/components';
import { __ } from '@wordpress/i18n';

Expand Down Expand Up @@ -68,22 +67,21 @@ export default function BoxInputControls( {
: selectedUnits[ corner ] || selectedUnits.flat;

return (
<Tooltip text={ label } placement="top" key={ corner }>
<div className="components-border-radius-control__tooltip-wrapper">
<UnitControl
{ ...props }
aria-label={ label }
value={ [ parsedQuantity, computedUnit ].join(
''
) }
onChange={ createHandleOnChange( corner ) }
onUnitChange={ createHandleOnUnitChange(
corner
) }
size="__unstable-large"
/>
</div>
</Tooltip>
<div
className="components-border-radius-control__tooltip-wrapper"
key={ corner }
>
<UnitControl
{ ...props }
label={ label }
value={ [ parsedQuantity, computedUnit ].join(
''
) }
onChange={ createHandleOnChange( corner ) }
onUnitChange={ createHandleOnUnitChange( corner ) }
size="__unstable-large"
/>
</div>
);
} ) }
</div>
Expand Down
Loading