Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tools panel: Synced the visible label and accessible name #68592

Open
wants to merge 1 commit into
base: trunk
Choose a base branch
from
Open

Tools panel: Synced the visible label and accessible name #68592

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 1 addition & 13 deletions packages/components/src/tools-panel/tools-panel-header/component.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,24 +98,12 @@ const OptionalControlsGroup = ( {
return (
<>
{ items.map( ( [ label, isSelected ] ) => {
const itemLabel = isSelected
? sprintf(
// translators: %s: The name of the control being hidden and reset e.g. "Padding".
__( 'Hide and reset %s' ),
label
)
: sprintf(
// translators: %s: The name of the control to display e.g. "Padding".
_x( 'Show %s', 'input control' ),
label
);

return (
<MenuItem
key={ label }
icon={ isSelected ? check : null }
isSelected={ isSelected }
label={ itemLabel }
label={ label }
onClick={ () => {
if ( isSelected ) {
speak(
Expand Down
Loading