Try: Fix e2e tests 'visitSiteEditor' helper

[Mamaduka]

What?

Trying to fix flaky tests like #61884.

I see a welcome modal in report files, which might be causing test failures.

Why?

The welcome modals should be hidden before asserting any other locators on a page.

Testing Instructions

CI checks should be green.

Testing Instructions for Keyboard

Same.

Screenshots or screencast

[github-actions]

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: Mamaduka <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

[github-actions]

Flaky tests detected in beb2a28.
Some tests passed with failed attempts. The failures may not be related to this commit but are still reported for visibility. See the documentation for more information.

🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/12654027603
📝 Reported issues:

• [Flaky Test] Redirection after template creation #60678 in /test/e2e/specs/site-editor/site-editor-url-navigation.spec.js

[Mamaduka]

Let's give this a try.

[Mamaduka]

It seems that the e2e test in question now fails most of the time on the trunk. I'll observe and revert this accordingly.