Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Bug/issue #68368 - SCRIPT_DEBUG not working properly in gutenberg plugin #68527

Open
wants to merge 1 commit into
base: trunk
Choose a base branch
from

Conversation

ronakganatra9
Copy link

What?

Before it was loading the minified version of javascript even the script_debug is turned on. ( It was only issue in gutenberg plugin )

Why?

After this PR merge, it will load minified version javascript when script debug is turned off and it will load non-minified version when script debug is turned on.

How?

So, Added changes as per the reference from WordPress develop
https://github.com/WordPress/wordpress-develop/blob/trunk/tools/webpack/script-modules.js
https://github.com/WordPress/wordpress-develop/blob/trunk/src/wp-includes/script-modules.php

Testing Instructions

  1. Merge PR
  2. Go to the wp-config.php file and enable script to debug to true define( 'SCRIPT_DEBUG', true );
  3. Check in console.

Screenshots or screencast

image
Before After
image image

Copy link

github-actions bot commented Jan 7, 2025

Warning: Type of PR label mismatch

To merge this PR, it requires exactly 1 label indicating the type of PR. Other labels are optional and not being checked here.

  • Type-related labels to choose from: [Type] Automated Testing, [Type] Breaking Change, [Type] Bug, [Type] Build Tooling, [Type] Code Quality, [Type] Copy, [Type] Developer Documentation, [Type] Enhancement, [Type] Experimental, [Type] Feature, [Type] New API, [Type] Task, [Type] Technical Prototype, [Type] Performance, [Type] Project Management, [Type] Regression, [Type] Security, [Type] WP Core Ticket, Backport from WordPress Core, Gutenberg Plugin.
  • Labels found: .

Read more about Type labels in Gutenberg. Don't worry if you don't have the required permissions to add labels; the PR reviewer should be able to help with the task.

Copy link

github-actions bot commented Jan 7, 2025

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Unlinked Accounts

The following contributors have not linked their GitHub and WordPress.org accounts: @ronakganatra-multidots.

Contributors, please read how to link your accounts to ensure your work is properly credited in WordPress releases.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Unlinked contributors: ronakganatra-multidots.


To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@github-actions github-actions bot added the First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository label Jan 7, 2025
Copy link

github-actions bot commented Jan 7, 2025

👋 Thanks for your first Pull Request and for helping build the future of Gutenberg and WordPress, @ronakganatra9! In case you missed it, we'd love to have you join us in our Slack community.

If you want to learn more about WordPress development in general, check out the Core Handbook full of helpful information.

@ronakganatra9 ronakganatra9 changed the title Fix issue #68368 - SCRIPT_DEBUG not working properly in gutenberg plugin Fix Bug/issue #68368 - SCRIPT_DEBUG not working properly in gutenberg plugin Jan 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants