StoryBook: Fix error that could occur when loading compiled CSS #68526
+17
−17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t-hamano
added
[Type] Bug
t-hamano
changed the title
t-hamano
commented
Jan 7, 2025
| @media (prefers-reduced-motion: no-preference) { | ||
| @media not (prefers-reduced-motion) { |
There was a problem hiding this comment.
This code was reverted in #68464 because it had errors in the trunk, but I've restored it in this PR since it should work correctly.
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: -23 B (0%) Total Size: 1.84 MB
ℹ️ View Unchanged
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See this comment: #68419 (comment)
What?
This PR fixes an issue where StoryBook may not be able to load compiled CSS when
@media notqueries are used.Why?
This issue was discovered during the work in #68282 to standardize the format for the
prefers-reduced-motionmedia feature.For example, write the following SCSS:
This code will be compiled into the following CSS:
This media query format is valid, but when you run Storybook, you will get the following error:
Details
How?
I don't know the exact cause, but I suspect that the compiled CSS file is being imported as an SCSS file.
Therefore, I explicitly define the extension in the import statement. This seems to allow the media query that causes the error to work correctly.
Testing Instructions
npm run storybook:dev.packages/components/src/button/style.scss:Buttoncomponent.Screenshots or screencast
Style applied to the button by the
@media (min-width: 782px) and (not (prefers-reduced-motion))query: