Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the Global Styles being Applied Incorrectly in Search Block #68515

Open
wants to merge 1 commit into
base: trunk
Choose a base branch
from

Conversation

Vedant-Gandhi
Copy link

What?

This PR addresses the issue where global styles are applied properly to indiviual text and button.

Why?

Issue - #68195

How?

This PR adds the experimental selectors to select the button and input element.

Testing Instructions

  1. Open the Site Editor using Appearance > Editor.
  2. Click on Style > Blocks.
  3. Select the Search Block and change the border color, width and radius.
  4. Ensure the styles are being applied to the indiviual input and button element.
  5. Now Create a new Post/Page and add the Search Block.
  6. Modify the border properties from sidebar panel and ensure they are being applied to the same elements.

Screenshots or screencast

final_change.mp4

@Vedant-Gandhi Vedant-Gandhi marked this pull request as ready for review January 7, 2025 06:03
Copy link

github-actions bot commented Jan 7, 2025

👋 Thanks for your first Pull Request and for helping build the future of Gutenberg and WordPress, @Vedant-Gandhi! In case you missed it, we'd love to have you join us in our Slack community.

If you want to learn more about WordPress development in general, check out the Core Handbook full of helpful information.

@github-actions github-actions bot added the First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository label Jan 7, 2025
Copy link

github-actions bot commented Jan 7, 2025

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: Vedant-Gandhi <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@carolinan carolinan added [Type] Bug An existing feature does not function as intended [Block] Search Affects the Search Block - used to display a search field labels Jan 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Search Affects the Search Block - used to display a search field First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants