Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NumberControl: Disable drag functionality on touch devices #68514

Open
wants to merge 1 commit into
base: trunk
Choose a base branch
from
Open

NumberControl: Disable drag functionality on touch devices #68514

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion packages/components/src/number-control/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,10 @@ import { maybeWarnDeprecated36pxSize } from '../utils/deprecated-36px-size';

const noop = () => {};

const isTouchDevice = () => {
return 'ontouchstart' in window || navigator.maxTouchPoints > 0;
};

function UnforwardedNumberControl(
props: WordPressComponentProps< NumberControlProps, 'input', false >,
forwardedRef: ForwardedRef< any >
Expand Down Expand Up @@ -219,6 +223,8 @@ function UnforwardedNumberControl(
},
} );

const shouldEnableDrag = isDragEnabled && ! isTouchDevice();

return (
<Input
autoComplete={ autoComplete }
Expand All @@ -227,7 +233,7 @@ function UnforwardedNumberControl(
className={ classes }
dragDirection={ dragDirection }
hideHTMLArrows={ spinControls !== 'native' }
isDragEnabled={ isDragEnabled }
isDragEnabled={ shouldEnableDrag }
label={ label }
max={ max }
min={ min }
Expand Down
Loading