-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Components: Restore Non-Themed Text Colors for optimizeReadabilityFor
#68472
Conversation
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.
To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Hi @mirka, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks for the quick revert! Could you also add a changelog, and revert the unit test changes as well so they pass again?
Thank you for the review, @mirka. 🙇 I’ve updated the CHANGELOG with the following text. Please let me know if you have any feedback or suggestions for improvement: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
…r` (WordPress#68472) * fix: Reverted to use non theme based CSS values * revert: Dark contrast tests for optimizeReadabilityFor, and updated CHANGELOG Co-authored-by: im3dabasia <[email protected]> Co-authored-by: mirka <[email protected]>
Follow up: #68349
Related comment: #68349 (comment)
What?
Reverted to using non-theme-based CSS values when the
optimizeReadabilityFor
prop is used, aligning with its intended functionality.Why?
The
optimizeReadabilityFor
prop takes a static background color as input. To ensure consistent readability, the corresponding text colors must remain as non-themed values.How?
Reverted the specific changes to
optimizeReadabilityFor
introduced in PR #68349