Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Calendar block todays date issue. #68460

Closed

Conversation

viralsampat-multidots
Copy link
Contributor

What?

I have fixed calendar block "Today's Date" highlighting issue. #68451

Why?

Today's date of "Calendar Block" is not highlighting in various themes.

How?

I have added style to highlight today's date in the calendar block itself.

Testing Instructions

  • Open post or page in edit mode.
  • Add Calendar block.
  • Check today's date in calendar and verify.

Screenshots or screencast

after_resolved_calendar_block_front_end
after_resolved_calendar_block

Thanks,

Copy link

github-actions bot commented Jan 2, 2025

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: viralsampat-multidots <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@akasunil akasunil added [Type] Enhancement A suggestion for improvement. [Block] Calendar Affects the Calendar Block labels Jan 3, 2025
@@ -36,6 +36,11 @@
&.has-text-color th {
color: inherit;
}
td {
&#today {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like a unnecessary high CSS specificity.

@t-hamano
Copy link
Contributor

t-hamano commented Jan 8, 2025

Closing based on this comment.

@t-hamano t-hamano closed this Jan 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Calendar Affects the Calendar Block [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The calendar block having issue with today date.
4 participants