Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Highlighting todays date #68458

Closed
wants to merge 1 commit into from
Closed

Highlighting todays date #68458

wants to merge 1 commit into from

Conversation

benazeer-ben
Copy link
Contributor

What?

Fixes #68451

Why?

Todays date is not highlighting in various themes.

How?

Added style to highlight todays date in the calendar block itself.

Testing Instructions

  • Open post or page in edit mode.
  • Add Calendar block.
  • Check today's date in calendar and verify.

Screenshots or screencast

Before After
Screenshot Screenshot (1)

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 2, 2025

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: benazeer-ben <[email protected]>
Co-authored-by: himanshupathak95 <[email protected]>
Co-authored-by: viralsampat-multidots <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@benazeer-ben
Copy link
Contributor Author

Instead of simply underlining today's date, we could enhance visibility by applying a background color to highlight it more effectively.

Additional suggestions and ideas are welcome!

Screenshot (2)

@t-hamano t-hamano mentioned this pull request Jan 5, 2025
Closed
@akasunil akasunil added [Type] Enhancement A suggestion for improvement. [Block] Code Affects the Code Block [Block] Calendar Affects the Calendar Block and removed [Block] Code Affects the Code Block labels Jan 6, 2025
@t-hamano
Copy link
Contributor

t-hamano commented Jan 8, 2025

Closing based on this comment.

@t-hamano t-hamano closed this Jan 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ajitbohra ajitbohra Awaiting requested review from ajitbohra ajitbohra is a code owner

@fabiankaegy fabiankaegy Awaiting requested review from fabiankaegy fabiankaegy is a code owner

Assignees

@benazeer-ben benazeer-ben

Labels
[Block] Calendar Affects the Calendar Block [Type] Enhancement A suggestion for improvement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The calendar block having issue with today date.
3 participants
@benazeer-ben @t-hamano @akasunil