-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change "Swap" to "Replace" for Template Action #68234
base: trunk
Are you sure you want to change the base?
Change "Swap" to "Replace" for Template Action #68234
Conversation
This reverts commit 63f81c1.
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Unlinked AccountsThe following contributors have not linked their GitHub and WordPress.org accounts: @bgardner, @kohheepeace. Contributors, please read how to link your accounts to ensure your work is properly credited in WordPress releases. If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.
To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
@bgardner - Please have a look at this PR when you get some time. |
@karthick-murugan Looks good to me Just tested with Playground and works as expected. |
@richtabor , @annezazu - Updated this PR with all necessary changes and fixed the End to End tests issues as well. Please review this PR when you get some time. |
Thanks for pinging. I'd drop this into #core-editor to get more reviews in WordPress.org slack! In quickly testing, this worked for me. |
@annezazu - Thanks for the review. Looking forward to it. |
What?
Fixes #56845
Updates the UI text from "Swap template" to "Replace template" for consistency across Gutenberg and to align with similar actions in the interface.
Why?
The word "replace" is commonly used in action items throughout the Gutenberg editor (e.g., replacing template parts). Using "swap" creates an inconsistency in terminology and could cause confusion.
Aligning this action with the existing terminology improves clarity and enhances the user experience by providing a consistent language framework.
How?
Replaced occurrences of "Swap template" with "Replace template" in the UI.
Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast
Before
After