Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change "Swap" to "Replace" for Template Action #68234

Open
wants to merge 20 commits into
base: trunk
Choose a base branch
from

Conversation

karthick-murugan
Copy link
Contributor

What?

Fixes #56845
Updates the UI text from "Swap template" to "Replace template" for consistency across Gutenberg and to align with similar actions in the interface.

Why?

The word "replace" is commonly used in action items throughout the Gutenberg editor (e.g., replacing template parts). Using "swap" creates an inconsistency in terminology and could cause confusion.

Aligning this action with the existing terminology improves clarity and enhances the user experience by providing a consistent language framework.

How?

Replaced occurrences of "Swap template" with "Replace template" in the UI.

Testing Instructions

  1. Go to the Site Editor.
  2. Select Pages and click on a page to edit.
  3. Open the Templates dropdown on the right-hand side of the screen.
  4. Verify that the action labeled "Swap template" is now labeled "Replace template".
  5. Click on the "Replace template" option and confirm that it functions as expected, with no changes to behaviour.

Testing Instructions for Keyboard

Screenshots or screencast

Before

Swap_template

After

replace_template

Copy link

github-actions bot commented Dec 23, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Unlinked Accounts

The following contributors have not linked their GitHub and WordPress.org accounts: @bgardner, @kohheepeace.

Contributors, please read how to link your accounts to ensure your work is properly credited in WordPress releases.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Unlinked contributors: bgardner, kohheepeace.

Co-authored-by: karthick-murugan <[email protected]>
Co-authored-by: annezazu <[email protected]>
Co-authored-by: richtabor <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@karthick-murugan karthick-murugan changed the title Rename/template action name Change "Swap" to "Replace" for Template Action Dec 23, 2024
@karthick-murugan
Copy link
Contributor Author

@bgardner - Please have a look at this PR when you get some time.

@bgardner
Copy link

bgardner commented Jan 6, 2025

@karthick-murugan Looks good to me Just tested with Playground and works as expected.

@karthick-murugan
Copy link
Contributor Author

@richtabor , @annezazu - Updated this PR with all necessary changes and fixed the End to End tests issues as well. Please review this PR when you get some time.

@annezazu
Copy link
Contributor

annezazu commented Jan 9, 2025

Thanks for pinging. I'd drop this into #core-editor to get more reviews in WordPress.org slack! In quickly testing, this worked for me.

@karthick-murugan
Copy link
Contributor Author

Thanks for pinging. I'd drop this into #core-editor to get more reviews in WordPress.org slack! In quickly testing, this worked for me.

@annezazu - Thanks for the review. Looking forward to it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Should "Swap template" be "Replace template" for consistency?
3 participants