Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: DataForm: datetime field update not reflected immediately in render component #68166

Open
wants to merge 1 commit into
base: trunk
Choose a base branch
from

Conversation

Rishit30G
Copy link
Contributor

What?

This PR fixes datetime field update not reflected immediately in render component when working with input

Why?

Issue Reported:

How?

This PR adds a new function handleInputChange which handles the input changes and calls buildNumberControlChangeCallback() with year or date depending on the input field

Testing Instructions

  • Ensure that add Quick Edit experiment is enabled
  • Visit wp-admin/site-editor.php?p=%2Fpage&layout=table&quickEdit=true
  • Select a page
  • Edit the date.
  • Change the day via character keys.
  • See that the preview isn't updated.
  • Change the day via navigation keys.
  • See that the preview is updated.

Screenshots or screencast

Screen.Recording.2024-12-20.at.12.21.04.PM.mov

@Rishit30G Rishit30G requested a review from ajitbohra as a code owner December 20, 2024 07:01
Copy link

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: Rishit30G <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@Mamaduka Mamaduka added [Type] Bug An existing feature does not function as intended [Feature] DataViews Work surrounding upgrading and evolving views in the site editor and beyond labels Jan 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] DataViews Work surrounding upgrading and evolving views in the site editor and beyond [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants