DuotonePicker: Simplify Button styles #66641
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mirka
added
[Type] Enhancement
|
Size Change: -20 B (0%) Total Size: 1.82 MB
ℹ️ View Unchanged
|
mirka
force-pushed
the
duotone-picker-40px
branch
from
e3a8cab to
f3b7757
Compare
mirka
commented
Nov 26, 2024
Comment on lines
-11
to
-12
| // Used to simulate styles as a .button.has-icon (which this component can't | ||
| // opt into, because it has to show more than a simple SVG as the "icon") |
There was a problem hiding this comment.
This is untrue, because the icon prop renders into an Icon component internally, which does support arbitrary components.
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
michalczaplinski
pushed a commit
that referenced
this pull request
Dec 5, 2024
* DuotonePicker: Simplify Button styles * Add changelog Co-authored-by: mirka <[email protected]> Co-authored-by: tyxla <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In preparation for #65751
What?
Simplifies the Button styles in DuotonePicker, so there are fewer overrides and matches the Figma specs better.
How?
Moves the button content (swatch and text) from
childrento the designated props on Button (<Button icon={} text={} />).Testing Instructions
See the Storybook for DuotonePicker.
Screenshots or screencast
The button heights are updated. The spacing between the swatch (
iconslot) and text is now aligned with the standard spacings.