Template Part: Add check if create action should be allowed #63623
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t-hamano
added
[Block] Template Part
|
Size Change: +72 B (0%) Total Size: 1.75 MB
ℹ️ View Unchanged
|
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Thanks, @t-hamano! I'll try to test this properly tomorrow. Re-caps issue: The "templates" endpoint is probably doing |
Mamaduka
reviewed
Jul 19, 2024
Comment on lines
+39
to
+42
| canCreateTemplatePart: canUser( 'create', { | ||
| kind: 'postType', | ||
| name: 'wp_template_part', | ||
| } ), |
There was a problem hiding this comment.
At this point, it seems like you can't modify the user caps required to create a template part, and anyone who can access this page will have edit_theme_options capabilities. This makes the current check redundant.
Templates endpoint permission check:
Mamaduka
approved these changes
Jul 19, 2024
|
@Mamaduka Thanks for the review!
Thanks for looking into this. As suggested in #61637, I think it's expected that in the future the site editor will be accessible to users without the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #58344
What?
This PR allows the creation of new template parts in a template part block only if the following conditions are met:
Why?
Creating template parts is not the intended behavior if the theme is not a block theme or if the user does not have the permissions.
How?
I added a check similar to the Add New Pattern button dropdown.
Another approach would be to not allow the insertion of template part blocks if the current theme is not a block theme, but I did allow the insertion of template part blocks because there might be edge cases where users want to nest template parts.
Testing Instructions
http://localhost:8889/wp-adminand activate theEmptyhybridtheme.🤔 About User Capabilities
Regarding user capabilities, I've come across an issue where we might not be able to disable the capability to create template parts.
I removed the
create_postscapability via the code below to test this PR:But strangely,
canUseralways returnstrueonly for template parts:This issue may need to be investigated separately.