Core Data: Use meta-store actions for resolution status #63469
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mamaduka
added
[Type] Code Quality
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Mamaduka
force-pushed
the
update/core-resolvers-use-meta-action-creators
branch
2 times, most recently
from
e86c0bc to
045f4ec
Compare
Mamaduka
force-pushed
the
update/core-resolvers-use-meta-action-creators
branch
from
045f4ec to
a4e4482
Compare
Mamaduka
commented
Jul 12, 2024
Comment on lines
+284
to
+287
| dispatch.finishResolutions( | ||
| 'getEntityRecord', | ||
| resolutionsArgs | ||
| ); |
There was a problem hiding this comment.
The actions are batched, so we only need finishResolutions.
There was a problem hiding this comment.
Any chance something external would be relying on starting resolution first before marking it as finished?
In other words, what do we lose if we keep both startResolutions and finishResolutions?
In case you want to go without startResolutions, should we add a comment about why we're skipping it?
There was a problem hiding this comment.
Related #63430 (comment)
There was a problem hiding this comment.
Thought might be the case. Thanks for confirming 👍
|
Size Change: -40 B (0%) Total Size: 1.75 MB
ℹ️ View Unchanged
|
|
Thank you, @tyxla! |
carstingaxion
pushed a commit
to carstingaxion/gutenberg
that referenced
this pull request
Jul 18, 2024
…3469) Co-authored-by: Mamaduka <[email protected]> Co-authored-by: tyxla <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
PR replaces hardcoded dispatches with meta-store actions for resolution status.
Testing Instructions
CI checks should be green.
Testing Instructions for Keyboard
Same.