Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrap long post titles to improve readability #62534

Closed
wants to merge 0 commits into from

Conversation

Anuj-Rathore24
Copy link

@Anuj-Rathore24 Anuj-Rathore24 commented Jun 13, 2024

What?

Fixes: #62414

  • Wrap long post titles to improve readability in post publish panel.

Why?

  • To improve user readability.

How?

  • use word-wrap css property.

Testing Instructions

  1. Go to permalink settings and set a custom structure of /%year%/%monthnum%/%day%/%postname%-%post_id%/
  2. Create a new post, give it a post name of /helloworldhelloworldhelloworld
  3. After opening Post Settings you can observe that the link preview wraps.

Screenshots or screencast

Screenshot 2024-06-13 at 3 18 41 PM

Copy link

github-actions bot commented Jun 13, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: Anuj-Rathore24 <[email protected]>
Co-authored-by: Soean <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@github-actions github-actions bot added the First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository label Jun 13, 2024
Copy link

👋 Thanks for your first Pull Request and for helping build the future of Gutenberg and WordPress, @Anuj-Rathore24! In case you missed it, we'd love to have you join us in our Slack community.

If you want to learn more about WordPress development in general, check out the Core Handbook full of helpful information.

Comment on lines 124 to 125
display: inline-block;
word-break: break-word;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where is this being used?

Copy link
Author

@Anuj-Rathore24 Anuj-Rathore24 Jun 13, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can check these changes in post publish panel,
Screenshot 2024-06-13 at 7 26 55 PM

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @Soean let me know if you need these changes, because it doesn't look that good and seems unnecessary!

@Soean
Copy link
Member

Soean commented Jun 13, 2024

Thanks for the pull request, the URL looks better now.

I can't find where post-publish-panel/style.scss is being used. How can I test it?

When the title is longer, we have the same problem at the top of the sidebar. Should we fix it too?
Bildschirmfoto 2024-06-13 um 15 39 19

@amitraj2203 amitraj2203 added [Type] Bug An existing feature does not function as intended [Feature] Link Editing Link components (LinkControl, URLInput) and integrations (RichText link formatting) labels Jun 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Link Editing Link components (LinkControl, URLInput) and integrations (RichText link formatting) First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Editor: Link preview overflows with long strings and only shows postname
3 participants