Fix: Resetting template part causes notification saying it's been delete #62521
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jorgefilipecosta
added
[Type] Bug
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: +98 B (+0.01%) Total Size: 1.76 MB
ℹ️ View Unchanged
|
|
Worked great! Tested for both resetting a template part and template for good measure. Video of template part: reset.notice.mov |
carolinan
reviewed
Jun 18, 2024
| ( item.has_theme_file || | ||
| ( item.templatePart && item.templatePart.has_theme_file ) ) | ||
| ); | ||
| console.log( { items } ); |
There was a problem hiding this comment.
I don't think the console.log is needed?
There was a problem hiding this comment.
Ah, I see that's what causing the static analysis error.
carolinan
approved these changes
Jun 18, 2024
jorgefilipecosta
force-pushed
the
fix/resetting-template-part-causes-snackbar-notification-saying-its-been-deleted
branch
from
fae32ce to
f27182d
Compare
jorgefilipecosta
deleted the
fix/resetting-template-part-causes-snackbar-notification-saying-its-been-deleted
branch
ellatrix
pushed a commit
that referenced
this pull request
Jun 25, 2024
…ete (#62521) Co-authored-by: jorgefilipecosta <[email protected]> Co-authored-by: carolinan <[email protected]> Co-authored-by: annezazu <[email protected]> Co-authored-by: ramonjd <[email protected]>
|
I just cherry-picked this PR to the wp/6.6-rc-1 branch to get it included in the next release: 0595c91 |
ellatrix
added
Backported to WP Core
ellatrix
pushed a commit
that referenced
this pull request
Jun 25, 2024
…ete (#62521) Co-authored-by: jorgefilipecosta <[email protected]> Co-authored-by: carolinan <[email protected]> Co-authored-by: annezazu <[email protected]> Co-authored-by: ramonjd <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #62458.
cc: @annezazu
Addresses an issue where for template parts when a revert happens we say they were deleted.
Testing Instructions
With 2024 theme installed apply some changes to the header template part.
Go to the patterns section template part do do a reset.
Verify we say the template part was reset not deleted as before.