Revert: Templates perf: resolve patterns server side #61708
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ellatrix
added
[Type] Bug
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
This pull request has changed or added PHP files. Please confirm whether these changes need to be synced to WordPress Core, and therefore featured in the next release of WordPress. If so, it is recommended to create a new Trac ticket and submit a pull request to the WordPress Core Github repository soon after this pull request is merged. If you're unsure, you can always ask for help in the #core-editor channel in WordPress Slack. Thank you! ❤️ View changed files❔ lib/load.php |
|
Size Change: 0 B Total Size: 1.75 MB ℹ️ View Unchanged
|
|
I no longer think we should revert, because resolving them client side is not great: we'd rely on having the patterns from the server, which we either need to get before loading the editor, or the resolving needs to be async. |
|
I think what makes most sense is only resolve for REST API endpoints: #61454 (comment) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Reverts #60349. Note that this will cause a perf hit for pattern loading, but I plan to follow-up with a client-side solution.
Why?
Fixes #61454. Server side hooks no longer run on this block.
How?
We can resolve pattern client-side, which will fix the hook issue, and is simpler. If we ever want to remove the patter block, we'll anyway have to resolve pattern also client side, because only removing them from our endpoints doesn't guarantee no pattern blocks slip in.
Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast