-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Block Editor: Remove multiline
prop from Richtext
doc
#61592
Conversation
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.
To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Indeed. If we want to add a migration guide, would it be better to use the Deprecation page? |
That page is for Deprecation API; we might need to find a better place :) |
We do log the prop as deprecated and link to the inner blocks documentation: gutenberg/packages/block-editor/src/components/rich-text/multiline.js Lines 30 to 35 in 2df566c
|
I think what developers would like to know is how to implement deprecation for migrating custom blocks containing RichText components with multiline prop to innerBlocks. For example, something like this function in the List block. gutenberg/packages/block-library/src/list/utils.js Lines 66 to 88 in 2df566c
Perhaps the Developer Blog is suitable for such implementation examples? |
@ellatrix, right, the deprecation notice links to InnerBlocks documentation, but based on the feedback, it seems that people are still struggling with migrations. @t-hamano, a post on the developers' blog sounds good to me. cc @ndiego @ryanwelcher |
I have never written for the Developer blog, but if the migration guide is useful to many people, I would be happy to help. By the way, I have already written code to test migrations in my personal repository: https://github.com/t-hamano/multiline-deprecation-example
I hope this code is useful. In any case, I would like to merge this PR. |
Sounds good. Thank you, @t-hamano! |
Closes #61580
What?
The
multiline
prop forRichText
components is now deprecated, so I removed it from the README.I thought about marking this prop as deprecated and keeping it, but just like when
onSplit
was deprecated, I removed the prop itself from the documentation.