Fix the RRS block placeholder labeling and improve spacing #61576
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
afercia
added
[Type] Bug
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: +56 B (0%) Total Size: 1.74 MB
ℹ️ View Unchanged
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #61571
What?
While the RSS block isn't exactly an 'embed' block, user interaction and styling of the block placeholder are very similar with other embed-related blocks. As such it should be consistent with these blocks in terms of labeling and styling.
From an a11y perspective, the input field isn't labeled in an appropriate way, as the accessible name is only given by the HTML
placeholderattribute. The input misses any associated<label>element oraria-labeloraria-labelledbyattributes.The button text 'Use URL' feels a little weird. A simpler, more intuitive text would be better.
Why?
All interactive controls should be labeled in an accessible and meaningful way. The placeholder attribute isn't a replacement for labeling.
Labeling and styling should be consistent.
How?
labelprop to the InputControl. The rendered label is visually hidden. The label text is 'RSS URL'.Display entries from any RSS or Atom feed.for two reasons:HStackcomponent and adjusts the spacing between the input and the button, for consistency with similar block placeholders.Testing Instructions
<label>element with text 'RSS URL'.Display entries from any RSS or Atom feed.Testing Instructions for Keyboard
Screenshots or screencast
Before:
After: