Only add the selected pattern category in metadata during insertion #61557
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ntsekouras
added
[Type] Enhancement
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: +994 B (+0.06%) Total Size: 1.74 MB
ℹ️ View Unchanged
|
ntsekouras
force-pushed
the
add-only-selected-pattern-category-in-metadata
branch
from
40bbc46 to
7e5fdd8
Compare
scruffian
reviewed
May 10, 2024
scruffian
reviewed
May 10, 2024
packages/block-editor/src/components/block-patterns-list/index.js
Outdated
Show resolved
Hide resolved
Co-authored-by: Ben Dwyer <[email protected]>
scruffian
approved these changes
May 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Alternative to #60088
What?
This PR preserves only the selected category in patterns metadata during insertion. We do this because this information is used for patterns shuffling and it makes sense to shuffle between the patterns of the initially selected category, as it can be confusing when we shuffle between multiple categories.
Testing Instructions
teamcategory, not theaboutcategory.Screenshots or screencast