Only show grid resizer if grid block allows resizing on children. #61552
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tellthemachines
added
[Type] Bug
tellthemachines
requested review from
noisysocks,
jasmussen,
ramonjd,
andrewserong and
fabiankaegy
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: +25 B (0%) Total Size: 1.74 MB
ℹ️ View Unchanged
|
andrewserong
approved these changes
May 10, 2024
There was a problem hiding this comment.
Good catch! This is testing well for me, with the resizer visible on the Grid block, but not when selecting the Post Template block.
I opted to still display the grid visualiser because I personally like clearly seeing where each spot in the grid starts and ends, but it could also be removed; feedback welcome!
I agree, I found it valuable when clicking through blocks to see the bounds of the Post Template block, particularly when there's no background color present, it helps make it clearer, I think:
LGTM, but also feel free to wait until you've got design feedback if you'd prefer! 🚀
|
Thanks for the review @andrewserong! I'll go ahead and merge this as it fixes the brokenness, but happy to iterate further on another PR if needed. |
|
⭐ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
The grid resizer should only appear when the parent block with grid layout explicitly sets
allowSizingOnChildren. This PR adds a check to only render the resizer if that attribute is present.Testing Instructions
Screenshots or screencast
Trunk:
This branch:
I opted to still display the grid visualiser because I personally like clearly seeing where each spot in the grid starts and ends, but it could also be removed; feedback welcome!