-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Zoom out: keep original viewport width (single scale) #61424
Merged
Merged
Changes from 12 commits
Commits
Show all changes
25 commits
Select commit
Hold shift + click to select a range
8c2981e
WIP
ajlende 7190822
Remove unused code
ajlende 18c8db1
Move containers into iframe
ajlende 64562a3
Refactor and move around listeners
ajlende edff3f9
Refactor order
ajlende 7d80ddd
Fix scale function call bug
ajlende 5cafcc8
Optimize rendering
ajlende dd77daa
Make constants constant
ajlende 96f330f
Use scale in all cases
ajlende 9c969d9
Don't use viewport width at full scale
ajlende f1a2b14
Revert bottom margin
ellatrix 7a6c007
minimize diff
ellatrix e528531
Merge branch 'trunk' into fix/iframe-scale-full-width
ajlende 5e23e99
Merge branch 'trunk' into fix/iframe-scale-full-width
ajlende f39a830
Merge branch 'trunk' into fix/iframe-scale-full-width
ajlende 182f9e0
Fix default
ajlende b0f642c
Revert name change
ajlende 60610d6
Revert name change
ajlende f7ef2d5
Reorder for better diff
ajlende e45ed23
Revert name change
ajlende 1a4f079
Fix zoom out frame
ajlende 54584eb
Finish merge
ajlende 45cc93a
Remove comment
ajlende 0904eb3
Try scaling to left sidebar width
ajlende b3bd4d8
use previous container width instead of a fixed value
scruffian File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The signature of this function changed, but the old function didn't make it into 6.5, so I think it's okay, but it might be a good idea to make the scale as a function a private API before the 6.6 release. We might want to move some of the logic elsewhere.