Testing: Remove react-test-renderer use
#61263
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tyxla
added
[Type] Automated Testing
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: 0 B Total Size: 1.74 MB ℹ️ View Unchanged
|
|
Interesting. Seems like we need to provide |
tyxla
changed the title
react-test-rendererreact-test-renderer use
Mamaduka
approved these changes
May 1, 2024
dcalhoun
reviewed
May 3, 2024
| * @param {Object} [options] Configuration options for the gesture event. | ||
| * @param {boolean} [options.failed] Determines if the gesture should fail. | ||
| * @param {number} [options.triggerIndex] In case there are multiple draggable triggers, this specifies the index to use. | ||
| * @param {HTMLElement} block Block test instance. |
There was a problem hiding this comment.
The (original) spirit of these changes make sense to me — removing a deprecated package.
However, given the package remains a peer dependency for testing-library/react-native for the time being and that React Native, to my understanding, doesn't support/relate to HTMLElement — for now, at least — these changes feel a bit misleading.
Not necessarily requesting a change or stating we must rollback the changes, merely sharing thoughts to see how others perceive this.
cc/ @WordPress/native-mobile
There was a problem hiding this comment.
Hmm, looks like you're right. I can't recall where I was looking when changing this initially, but it doesn't seem to make sense.
In any case, the original purpose of the PR failed, so I'm happy to revert, see #61439.
tyxla
added a commit
that referenced
this pull request
May 7, 2024
This reverts commit 28054e3. Co-authored-by: tyxla <[email protected]> Co-authored-by: Mamaduka <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This PR is replacing the last (jsdoc/ts) usages of
react-test-rendererand removing the dependency altogetherWhy?
We're soon planning to update to React 19 and it deprecates
react-test-renderer.I started this in hopes I could remove the dependency, but that's not possible just yet - it's still needed.
Anyway, we can remove the imports in types/jsdoc at least.
How?
We're changing the
import('react-test-renderer').ReactTestInstancetype toHTMLElement, which it essentially is under the hood.This removes its usage in docs Ideally we should remove the dependency, but right now it's necessary for
@testing-library/react-native.Testing Instructions
All checks should be green.
Testing Instructions for Keyboard
None
Screenshots or screencast
None