Refactor format function and add createMomentDate function #61260
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Creates a function
createMomentDate
that allows creating a moment object by passing a date string and a PHP-style format that gets converted using theformatMap
object.Why?
In the PR woocommerce/woocommerce#46932 implemented this outside of the
@wordpress/date
library to deal with a bug in Chinese date formats.How?
It uses the existing
formatMap
object and creates a new function to create the moment object from the date and the PHP-style date format.Testing Instructions
No manual tests needed, it has unit tests.
Testing Instructions for Keyboard
Screenshots or screencast