Remove usage of aria-details from InputControl and BaseControl. #61203
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
afercia
added
[Type] Bug
|
Size Change: -33 B (0%) Total Size: 1.74 MB
ℹ️ View Unchanged
|
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
@WordPress/gutenberg-core I'd appreciate a review, when anyone of you has a chance 🙇🏽♂️ |
Mamaduka
approved these changes
May 9, 2024
There was a problem hiding this comment.
Thanks, @afercia!
The reasoning makes sense and changes the test for me well.
It also seems that DevTools a11y tools have better handling for aria-describedby; previously, it did not render the aria-details value in the panel.
Screenshot
It didn't because |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #61189
What?
InputControl and BaseControl use some conditional logic to render an
aria-detailsattribute instead of anaria-describedbyattribute when the passedhelpprop is a component. However,aria-details:aria-describedbyas the description is not announced automatically by screen readers and requires manual interactionaria-describedbyand the resulting string does not contain markup.Why?
We do want description to be automatically announced by screen readers when users focus an input field.
How?
Revers the impelmentation of
aria-detailsintroeuced in #45931 and #46170.Testing Instructions
aria-describedbyattribute that points to the paragraph that contains the full permalink below the input field.Testing Instructions for Keyboard
Screenshots or screencast