Consolidate editor/canvas resize handles #60712
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juanfra
added
[Type] Enhancement
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: -6.02 kB (-0.34%) Total Size: 1.74 MB
ℹ️ View Unchanged
|
|
Nice! We need to account for the focus style here. I'm not sure if the one in the edit-site-resizable-frame__inner does not have one, but they should be 1:1 (and perhaps focus:visible).
I also noted the drag handle in focus mode is a bit different height, and gets smaller + thicker on selection. I think the "grab" effect of it getting smaller is fine, but not thicker. If both handles responded like that, we'd be solid. |
|
Thanks for reviewing, Rich! Indeed, the focus state was an oversight. I'll push fixes to your comments soon. |
t-hamano
reviewed
May 1, 2024
| border-radius: $radius-block-ui; | ||
| } | ||
|
|
||
| &.is-left { | ||
| left: -$grid-unit-20; | ||
| // Subtract half of the handle width to properly center. | ||
| left: -$grid-unit-20 - ($grid-unit-05 / 2); |
There was a problem hiding this comment.
This notation will alert us to a warning error when starting or building the project.
You'll probably need to change it to something like this:
left: -$grid-unit-20 - math.div($grid-unit-05, 2);
jasmussen
reviewed
May 2, 2024
| } | ||
|
|
||
| &.is-right { | ||
| right: -$grid-unit-20; | ||
| // Subtract half of the handle width to properly center. | ||
| right: -$grid-unit-20 - ($grid-unit-05 / 2); |
There was a problem hiding this comment.
@juanfra this is causing a deprecation warning:
You can fix it with right: -$grid-unit-20 - ($grid-unit-05 * 0.5).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Consolidate the resize handles.
Fixes: #60053
Why?
To have the resize handles looking and working the same way in the different touchpoints, bringing a more cohesive experience.
How?
Applying the same styles, relying on the admin theme accent, and adding the motion effect for the resize handle within the editor.
Testing Instructions
Screenshots or screencast
resize-canvas.mov