Adjust block selection button #60348
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
draganescu
added
[Type] Enhancement
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
It's a known issue that the toolbar is missing some separators. But that stems also from the fact that it's historically implemented as a flex group not as a navigable toolbar. To make it a toolbar some refactoring is required and I'd like that in a specific PR. |
|
Size Change: -297 B (0%) Total Size: 1.73 MB
ℹ️ View Unchanged
|
We should have the same conditional that omits the drag control when the block is locked. Viewing a locked post title block:
|
draganescu
force-pushed
the
fix/block-select-button
branch
from
ea50e31 to
b202116
Compare
draganescu
force-pushed
the
fix/block-select-button
branch
from
b202116 to
20fcf0f
Compare
|
When I'm in I think we can refactor so that the block dragger component is only there once. |
scruffian
reviewed
Apr 3, 2024
Comment on lines
+284
to
+286
| const showBlockDraggable = | ||
| ( canMove && editorMode === 'navigation' ) || | ||
| ( editorMode === 'zoom-out' && canMove && ! isBlockTemplatePart ); |
There was a problem hiding this comment.
Maybe this is easier to read?
Suggested change
| const showBlockDraggable = | |
| ( canMove && editorMode === 'navigation' ) || | |
| ( editorMode === 'zoom-out' && canMove && ! isBlockTemplatePart ); | |
| const showBlockDraggable = canMove && | |
| ( editorMode === 'navigation' || ( editorMode === 'zoom-out' && ! isBlockTemplatePart ) ); |
There was a problem hiding this comment.
Suggested change
| const showBlockDraggable = | |
| ( canMove && editorMode === 'navigation' ) || | |
| ( editorMode === 'zoom-out' && canMove && ! isBlockTemplatePart ); | |
| const showBlockDraggable = | |
| ( canMove && editorMode === 'navigation' ) || | |
| ( canMove && editorMode === 'zoom-out' && ! isBlockTemplatePart ); |
Changing the order also makes it more readable.
There was a problem hiding this comment.
In general, I think all the inline conditions below could be brought up here to make things more readable too.
scruffian
approved these changes
Apr 3, 2024
cbravobernal
pushed a commit
to garridinsi/gutenberg
that referenced
this pull request
Apr 9, 2024
* adds drag button to zoom out, rearranges buttons, removes block name in zoom out * remove double block mover
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Advances #60124
Why?
To improve the toolbar available in zoom out mode.
How?
Testing Instructions
Testing Instructions for Keyboard
N/A
Screenshots or screencast