Fix issue with appender jumping when creating a new pattern. #59582
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: +35 B (0%) Total Size: 1.71 MB
ℹ️ View Unchanged
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Related to #59550. Fix issue where the empty appender jumps when going from the appender button to the paragraph block.
How?
Margin rules exist to zero out the top margin of the first paragraph block, and the bottom margin of the last. Those rules do not exist for the incarnation of the paragraph appender, when used in the "create new pattern" flow. This appender is a button component that exists in the canvas as a prompt to start typing, so that the document can be empty until you actually click it and a paragraph block is added.
This PR fixes it by adding the rules needed. Before, a shift:
After, no shift:
Testing Instructions
Test empty documents across the editor. New pages, new posts, new patterns, anything that has the empty appender. There should be no layout shift when going from the truly empty state of the document, to the one where an empty paragraph block has been inserted.