-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Social Links: add Bluesky logo #57277
Conversation
Warning: Type of PR label mismatch To merge this PR, it requires exactly 1 label indicating the type of PR. Other labels are optional and not being checked here.
Read more about Type labels in Gutenberg. Don't worry if you don't have the required permissions to add labels; the PR reviewer should be able to help with the task. |
Unfortunately the test does not work The bluesky button is now available for download from the official website https://blueskyweb.xyz/blog/press-faq Here is the link : https://drive.google.com/drive/folders/16mlJPfWNnc6jj-3vGZ88SFysIY13GBp0 |
I believe you're referring to the "Enforce labels on Pull Request" test? This can only be addressed by folks who have admin access on this repository, I'm afraid, so we'll need to wait until they review this Pull Request.
Yes, that's the logo used on this Pull Request. |
There's a duplicate issue over at Automattic/wp-calypso#87249 (comment) — I don't know if Gutenberg adding the icon would negate the Calypso issue or not. Regardless, since Bluesky is officially open for all, it would make sense to prioritize the addition of their icon in an upcoming release. |
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.
To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
@ajitbohra seems this merge is being held up by an issue that has no bearing on the icon itself. |
Looks like #61372 was open and merged, so this is now unnecessary. I'll close it. |
What?
This introduces a new Social Link icon, for the Bluesky service. The icon was made official a few months ago, in this post.
Why?
Bluesky, despite being a fairly new addition to the social network scene, has quickly become quite popular as an alternative to Twitter. It could be useful for site owners to want to list their Bluesky profile alongside their other social media presences.
How?
This adds the new icon and service, as well as tests.
Testing Instructions
Testing Instructions for Keyboard
Same as above, this behavior does not change in this PR.
Screenshots or screencast