Modal: make everything outside inert
#53829
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stokesman
added
[Type] Bug
stokesman
force-pushed
the
update/modal-aria-inert
branch
from
6b08003 to
97232f0
Compare
|
Flaky tests detected in 97232f0. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/7579442555
|
stokesman
force-pushed
the
update/modal-aria-inert
branch
from
97232f0 to
c7fbbc5
Compare
|
Size Change: +4 B (0%) Total Size: 1.84 MB
ℹ️ View Unchanged
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Bug fix/enhancement to
Modalcomponent.Why?
I think
inertis what we'd have used from the get go had it been well supported then.To fix #41503
This should also help with other obscure problems like one that can be triggered by undo/redo keyboard shortcuts while a Modal is open.
How?
Updates use of
aria-hiddentoinert.Testing Instructions