Add image block aspect ratio control#51545

Merged

scruffian merged 116 commits intotrunkfrom add/image-block-aspect-ratio-control

Jun 23, 2023

+1,708-238

Commits on Jun 23, 2023

Simplify ImageSizeControl by using Auto as a placeholder

Alex Lende
authored and
scruffian
committed
Rename imageWidth and imageHeight props to naturalWidth and naturalHeight

Alex Lende
authored and
scruffian
committed
Convert NumberControl onChange values to Numbers

Alex Lende
authored and
scruffian
committed
Simplify LatestPostsEdit to use updated ImageSizeControl

Alex Lende
authored and
scruffian
committed
Add JSDoc types for debugging

Alex Lende
authored and
scruffian
committed
Remove unnecessary noop

Alex Lende
authored and
scruffian
committed
Fix possible undefined values in NumberControl onChange

Alex Lende
authored and
scruffian
committed
Fix onChangeImage param type which may be undefined

Alex Lende
authored and
scruffian
committed
Rename OnChange callback prop

Alex Lende
authored and
scruffian
committed
Inline JSDoc props instead of new object

Alex Lende
authored and
scruffian
committed
Simplify handing undefined and NaN in onChange

Alex Lende
authored and
scruffian
committed
Revert prop name change since this isn't a private API

Alex Lende
authored and
scruffian
committed
Add a privateApis export for experimental ImageSizeControl

Alex Lende
authored and
scruffian
committed
Use the privateApis version of ImageSizeControl

Alex Lende
authored and
scruffian
committed
Add deprecation notice to the original component

Alex Lende
authored and
scruffian
committed
Revert image-size-control and create image-dimensions-control instead

Alex Lende
authored and
scruffian
committed
Re-add deprecation notice to image-size-control

Alex Lende
authored and
scruffian
committed
Try making a whole new component

Alex Lende
authored and
scruffian
committed
Revert changes to image, latest-posts, and media-text blocks

Alex Lende
authored and
scruffian
committed
Organize and update the dimensions tool panel item

Alex Lende
authored and
scruffian
committed
Reword size help text

Alex Lende
authored and
scruffian
committed
Reorganize into reusable components

Alex Lende
authored and
scruffian
committed
Add stories for other individual tools

Alex Lende
authored and
scruffian
committed
Update stories path

Alex Lende
authored and
scruffian
committed
Remove SelectControl __next prop

Alex Lende
authored and
scruffian
committed
Pass through isShownByDefault to ResolutionTool

Alex Lende
authored and
scruffian
committed
Remove unused scss

Alex Lende
authored and
scruffian
committed
Deprecate experimental ImageSizeControl

Alex Lende
authored and
scruffian
committed
Simplify ScaleTool onChange

Alex Lende
authored and
scruffian
committed
Add better defaults for value and onChange

Alex Lende
authored and
scruffian
committed
Fix circular dependency

Alex Lende
authored and
scruffian
committed
Update comment about auto and custom aspect ratios

Alex Lende
authored and
scruffian
committed
Add JSDoc types for ScaleTool

Alex Lende
authored and
scruffian
committed
Add JSDoc types for WidthHeightTool

Alex Lende
authored and
scruffian
committed
Add default value and onChange for WidthHeightTool

Alex Lende
authored and
scruffian
committed
Remove unused import

Alex Lende
authored and
scruffian
committed
Add aspectRatio to image block attributes

Alex Lende
authored and
scruffian
committed
Add scale to image block attributes

Alex Lende
authored and
scruffian
committed
Update JSDoc comment

ajlende
authored and
scruffian
committed
Add dimensions tool to image block

ajlende
authored and
scruffian
committed
Rename naturalAspectRatio for clarity

ajlende
authored and
scruffian
committed
Fix aspect-ratio-tool lint

ajlende
authored and
scruffian
committed
Fix scale-tool lint

ajlende
authored and
scruffian
committed
Fix width-height-tool lint

ajlende
authored and
scruffian
committed
Fix dimensions-tool lint

ajlende
authored and
scruffian
committed
Fix resolution-tool lint

ajlende
authored and
scruffian
committed
Add @emption/styled to block-editor

ajlende
authored and
scruffian
committed
Fix image block lint

ajlende
authored and
scruffian
committed
Update components changelog

ajlende
authored and
scruffian
committed
Fix AspectRatioTool reference

ajlende
authored and
scruffian
committed
Support 'auto' in width-height-tool

ajlende
authored and
scruffian
committed
Make null/undefined values mean 'auto' instead of defaultValue in aspectRatioTool

ajlende
authored and
scruffian
committed
Add deprecation for image block

ajlende
authored and
scruffian
committed
Fix ResizableBox interactions

ajlende
authored and
scruffian
committed
Add comments for default values

ajlende
authored and
scruffian
committed
Fix ResizableBox with auto w/h

ajlende
authored and
scruffian
committed
Clear aspect-ratio on resize

ajlende
authored and
scruffian
committed
Add TODO comment for ResolutionTool defaultValue

ajlende
authored and
scruffian
committed
Move the scale hide/show into dimensions controls

ajlende
authored and
scruffian
committed
Add first test

ajlende
authored and
scruffian
committed
Fix scale being set after it was deleted

ajlende
authored and
scruffian
committed
WIP writing tests

ajlende
authored and
scruffian
committed
Update test

ajlende
authored and
scruffian
committed
UI tweaks

richtabor
authored and
scruffian
committed
Move alt text as ToolsPanelItem

richtabor
authored and
scruffian
committed
Tweak default scale option help text

richtabor
authored and
scruffian
committed
Only use contain and cover for image scale options

richtabor
authored and
scruffian
committed
Update test

ajlende
authored and
scruffian
committed
Test the remaining callback values

ajlende
authored and
scruffian
committed
Add comment about toStrictEqual

ajlende
authored and
scruffian
committed
Add test for setting custom aspect ratio and then resetting

ajlende
authored and
scruffian
committed
Move custom scaleOptions to the image block

ajlende
authored and
scruffian
committed
Remember last aspect ratio so it can be restored when with/height are unset then set

ajlende
authored and
scruffian
committed
Remove unused import

ajlende
authored and
scruffian
committed
Format code

ajlende
authored and
scruffian
committed
Remove image w/h reset when a new image is added

ajlende
authored and
scruffian
committed
Use UnitControl's default units instead of spacing.units

ajlende
authored and
scruffian
committed
Provide the complete set of object-fit options by default

ajlende
authored and
scruffian
committed
Update TODO that will be committed

ajlende
authored and
scruffian
committed
Clean up evalAspectRatio and add docs

ajlende
authored and
scruffian
committed
Someone can file a bug report if offsetWidth/offsetHeight causes issues

ajlende
authored and
scruffian
committed
I couldn't figure out why height depended on having a custom border, but things seem to work without that

ajlende
authored and
scruffian
committed
Update docs for image block

ajlende
authored and
scruffian
committed
Update comment about default value

ajlende
authored and
scruffian
committed
Fix redundant wording

ajlende
authored and
scruffian
committed
I think the img width and height attributes can be removed if they're specified in the style attribute

ajlende
authored and
scruffian
committed
Update package-lock.json with @emotion/styled dependency

ajlende
authored and
scruffian
committed
Update mock calls for test example

ajlende
authored and
scruffian
committed
Simplify test values

ajlende
authored and
scruffian
committed
Consolidate mock calls expect

ajlende
authored and
scruffian
committed
Require defaultScale and defaultAspectRatio for DimensionsTool

ajlende
authored and
scruffian
committed
Add DimensionsTool tests for all custom transitions

ajlende
authored and
scruffian
committed
Remove comment about matching aspect ratio options

ajlende
authored and
scruffian
committed
Remove redundant check in tests

ajlende
authored and
scruffian
committed
Add comments to defaultAspectRatio and defaultScale

ajlende
authored and
scruffian
committed
Organize tests by which field is being updated

ajlende
authored and
scruffian
committed
Fix type conversion

ajlende
authored and
scruffian
committed
Add state diagram for last two tests

ajlende
authored and
scruffian
committed
Refactor and fix some tests

ajlende
authored and
scruffian
committed
Fix and simplify WidthHeightTool onChange

ajlende
authored and
scruffian
committed
Remove default scale option in image block.json

ajlende
authored and
scruffian
committed
Simplify DimensionsTool onChange logic

ajlende
authored and
scruffian
committed
Update block deprecations with width and height

ajlende
authored and
scruffian
committed
Revert image block width and height attributes to numbers since we only support px units for now

ajlende
authored and
scruffian
committed
Revert "Update block deprecations with width and height"

ajlende
authored and
scruffian
committed
Prevent NaN width/height

ajlende
authored and
scruffian
committed
Fix DimensionTool width/height units

ajlende
authored and
scruffian
committed
Fix JSDoc Dimenstions width/height types

ajlende
authored and
scruffian
committed
No default needed for ResolutionTool

ajlende
authored and
scruffian
committed
Fix drag handle aspect ratio reset

ajlende
authored and
scruffian
committed
Simplify null checks

ajlende
authored and
scruffian
committed
Stop using pxWidth and pxHeight

ajlende
authored and
scruffian
committed
Remove e2e tests that reference the scale button that was removed

ajlende
authored and
scruffian
committed
Fix image scaling for small images

ajlende
authored and
scruffian
committed
Try fixing aspectRatio only images

ajlende
authored and
scruffian
committed
Update test to respect the new aspect ratio behavior

jeryj
authored and
scruffian
committed