-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Block editor: add a keyboard shortcut to create group from the selected blocks #46972
Merged
t-hamano
merged 12 commits into
trunk
from
enhancement/shorcut-selected-blocks-to-group
May 10, 2024
Merged
Changes from 6 commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
f329fa4
Block editor: add a keyboard shortcut to create group from the select…
t-hamano b9a333d
Merge branch 'trunk' into enhancement/shorcut-selected-blocks-to-group
t-hamano e942a9d
Change modifier key
t-hamano 0133889
Merge branch 'trunk' into enhancement/shorcut-selected-blocks-to-group
t-hamano 7b16ecd
Update faq.md
t-hamano cb958e5
Display shortcut in the block toolbar options menu
t-hamano ff9aea7
Merge branch 'trunk' into enhancement/shorcut-selected-blocks-to-group
t-hamano 8cf7f34
Add spoken message
t-hamano 4b69935
Enable shortcut in the list view
t-hamano 20866f8
Merge branch 'trunk' into enhancement/shorcut-selected-blocks-to-group
t-hamano 31d9f7f
Keep focus within the list view
t-hamano 170be3f
Merge branch 'trunk' into enhancement/shorcut-selected-blocks-to-group
t-hamano File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A spoken message when grouping is successful might be a good affordance. I tested with voiceover and there's not any indication that anything happens.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated by 8cf7f34
When you run the shortcut, you should hear "Selected blocks are grouped.".
Video tested with NVDA:
7274217df9cd891d1cc3d9bcedd95b7d.mp4
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
By the way, we may need to add a spoken message to other shortcuts as well. See #61168.