Add styling for disabled options in ToggleGroupControl and try polish #34945
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While working on #34893, I found that
ToggleGroupControl
has no styling for disabled options. It gets an inlinepointer-events: none
thanks to Reakit but that's it. So mainly this PR is about adding some basic styles to help differentiate disabled states. I think the difference may be too subtle but I'd like to get some feedback.Besides that there are two more small changes that I think are improvements.
LabelPlaceholderView
because it is both visually and aria-hidden. I removed it and still can't figure out what it does. I will not be surprised if I'm missing something and have to restore this though.How has this been tested?
Manually
Screenshots
Disabled Styles
Options 1 & 2 are disabled
Post Featured Image block inspector
Types of changes
Enhancement
Checklist:
*.native.js
files for terms that need renaming or removal).