Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed the description text of block movers for horizontal movement on multiple selection #32337

Conversation

thisissandip
Copy link
Contributor

Fixes #25158

Description

The description text of the blocks which can be moved horizontally was not correct on multiple selection.
Refer #25158

How has this been tested?

  1. Select a block that can be moved horizontally (eg. Buttons Block)
  2. Add 2 to 3 blocks to move them around
  3. Select multiple blocks
  4. Inspect the block mover buttons
  5. The correct descriptive text should be displayed according to the orientation of the blocks

Screenshots

Screenshot 2021-05-30 at 8 02 29 PM

Types of changes

Bug fix

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • I've tested my changes with keyboard and screen readers.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.

@thisissandip thisissandip requested a review from ellatrix as a code owner May 30, 2021 14:40
@annezazu annezazu added [Type] Bug An existing feature does not function as intended [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). General Interface Parts of the UI which don't fall neatly under other labels. labels Aug 25, 2021
@t-hamano
Copy link
Contributor

I would like to test this PR based on bug scrubs.
It needs to be rebased first, but it will work fine 👍

@t-hamano
Copy link
Contributor

Hi @thisissandip,

I needed your PR to reflect the latest trunk, so I imported your branch into gutenberg repository and created a new PR.
Therefore, I would like to close this PR.

Also, the unit tests failed and I would like to resolve that in the new PR.

Of course, your credit is also reflected in the commit.

I appreciate your contribution 😄

@t-hamano t-hamano closed this Jul 13, 2022
@thisissandip
Copy link
Contributor Author

Thanks for taking over @t-hamano!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). General Interface Parts of the UI which don't fall neatly under other labels. [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Movers: description text for horizontal movement is incorrect with multiple selection
3 participants