Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Store screenshots of CI e2e failures as CI artifacts #26664

Merged
merged 5 commits into from
Nov 12, 2020
+84 −0
Merged

Store screenshots of CI e2e failures as CI artifacts #26664

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
d0e4737
squash
adamziel Nov 12, 2020
691d140
Remove artifacts
adamziel Nov 12, 2020
0725e4d
Rename screenshots to artifacts
adamziel Nov 12, 2020
2d45bcd
remove usages
adamziel Nov 12, 2020
5238318
fix broken test
adamziel Nov 12, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
fix broken test
  • Loading branch information
@adamziel
adamziel committed Nov 12, 2020
commit 5238318396d1d7a741088d9f0c7d4a47306016fe
2 changes: 1 addition & 1 deletion packages/e2e-tests/specs/experiments/multi-entity-editing.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -237,7 +237,7 @@ describe( 'Multi-entity editor states', () => {
);
await page.keyboard.type( 'Nested test words!' );

expect( await isEntityDirty( templateName ) ).toBe( true ); // Broken on purpose to test the screenshots
expect( await isEntityDirty( templateName ) ).toBe( false );
expect( await isEntityDirty( templatePartName ) ).toBe( false );
expect( await isEntityDirty( nestedTPName ) ).toBe( true );
} );
Expand Down