Revert combobox changes

WordPress · Jan 31, 2025 · d72a94c · d72a94c
1 parent 8d69880
commit d72a94c
Show file tree

Hide file tree

Showing 4 changed files with 2 additions and 20 deletions.
diff --git a/packages/components/src/combobox-control/README.md b/packages/components/src/combobox-control/README.md
@@ -39,7 +39,6 @@ function MyComboboxControl() {
 			label="Font Size"
 			value={ fontSize }
 			onChange={ setFontSize }
-			isLoading={ isLoading }
 			options={ filteredOptions }
 			onFilterValueChange={ ( inputValue ) =>
 				setFilteredOptions(
@@ -113,20 +112,13 @@ If the control is clicked, the dropdown will expand regardless of this prop.
 -   Required: No
 -   Default: `true`
 
-#### placeholder
+### placeholder
 
 If passed, the combobox input will show a placeholder string if no values are present.
 
 -   Type: `string`
 -   Required: No
 
-#### isLoading
-
-Show a spinner (and hide the suggestions dropdown) while data about the matching suggestions (ie the `options` prop) is loading
-
--   Type: `Boolean`
--   Required: No
-
 #### __experimentalRenderItem
 
 Custom renderer invoked for each option in the suggestion list. The render prop receives as its argument an object containing, under the `item` key, the single option's data (directly from the array of data passed to the `options` prop).

diff --git a/packages/components/src/combobox-control/index.tsx b/packages/components/src/combobox-control/index.tsx
@@ -35,7 +35,6 @@ import type { TokenInputProps } from '../form-token-field/types';
 import { useDeprecated36pxDefaultSizeProp } from '../utils/use-deprecated-props';
 import { withIgnoreIMEEvents } from '../utils/with-ignore-ime-events';
 import { maybeWarnDeprecated36pxSize } from '../utils/deprecated-36px-size';
-import Spinner from '../spinner';
 
 const noop = () => {};
 
@@ -127,7 +126,6 @@ function ComboboxControl( props: ComboboxControlProps ) {
 		help,
 		allowReset = true,
 		className,
-		isLoading = false,
 		messages = {
 			selected: __( 'Item selected.' ),
 		},
@@ -364,7 +362,6 @@ function ComboboxControl( props: ComboboxControlProps ) {
 								onChange={ onInputChange }
 							/>
 						</FlexBlock>
-						{ isLoading && <Spinner /> }
 						{ allowReset && (
 							<Button
 								size="small"
@@ -378,7 +375,7 @@ function ComboboxControl( props: ComboboxControlProps ) {
 							/>
 						) }
 					</InputWrapperFlex>
-					{ isExpanded && ! isLoading && (
+					{ isExpanded && (
 						<SuggestionsList
 							instanceId={ instanceId }
 							// The empty string for `value` here is not actually used, but is

diff --git a/packages/components/src/combobox-control/stories/index.story.tsx b/packages/components/src/combobox-control/stories/index.story.tsx
@@ -124,7 +124,6 @@ WithCustomRenderItem.args = {
 			</div>
 		);
 	},
-	isLoading: true,
 };
 
 /**

diff --git a/packages/components/src/combobox-control/types.ts b/packages/components/src/combobox-control/types.ts
@@ -86,10 +86,4 @@ export type ComboboxControlProps = Pick<
 	 * If passed, the combobox input will show a placeholder string if no values are present.
 	 */
 	placeholder?: string;
-
-	/**
-	 * Show a spinner (and hide the suggestions dropdown) while data
-	 * about the matching suggestions (ie the `options` prop) is loading
-	 */
-	isLoading?: boolean;
 };
-Original file line number
+Diff line change
@@ Expand Up / @@ -124,7 +124,6 @@ WithCustomRenderItem.args = { @@
     			</div>
     		);
     	},
-    	isLoading: true,
     };
     /**
@@ Expand Down @@