Block Bindings: Fix button popover not showing in patterns (#58219)

* Use `lockUrlControls` variable in button * Add `linkTarget` to JS allowed blocks object
WordPress · Jan 24, 2024 · 0c216f1 · 0c216f1
1 parent 5b4c751
commit 0c216f1
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/packages/block-editor/src/hooks/use-bindings-attributes.js b/packages/block-editor/src/hooks/use-bindings-attributes.js
@@ -26,7 +26,7 @@ const BLOCK_BINDINGS_ALLOWED_BLOCKS = {
 	'core/paragraph': [ 'content' ],
 	'core/heading': [ 'content' ],
 	'core/image': [ 'url', 'title', 'alt' ],
-	'core/button': [ 'url', 'text' ],
+	'core/button': [ 'url', 'text', 'linkTarget' ],
 };
 
 const createEditFunctionWithBindingsAttribute = () =>

diff --git a/packages/block-library/src/button/edit.js b/packages/block-library/src/button/edit.js
@@ -336,7 +336,7 @@ function ButtonEdit( props ) {
 			{ isLinkTag &&
 				isSelected &&
 				( isEditingURL || isURLSet ) &&
-				! metadata?.bindings?.url && (
+				! lockUrlControls && (
 					<Popover
 						placement="bottom"
 						onClose={ () => {