Components: Split MenuItem label and description for accessibility
#125484
im3dabasiaunit-test.yml
on: pull_request
Compute previous WordPress version
0s
Build JavaScript assets for PHP unit tests
4m 47s
PHP coding standards
24s
Mobile
4m 18s
Matrix: unit-js-date
Matrix: unit-js
Matrix: test-php
PHP
0s
Annotations
4 errors and 10 warnings
|
JavaScript (Node.js 22) 4/4:
packages/components/src/menu-item/test/index.js#L62
Error: expect(received).toMatchSnapshot()
Snapshot name: `MenuItem should match snapshot when info is provided 1`
- Snapshot - 0
+ Received + 10
@@ -1,6 +1,8 @@
<button
+ aria-describedby="menu-item-description-aeea3f06-6823-443c-8f7b-3a763318db23"
+ aria-labelledby="menu-item-label-cd947a26-61c7-4240-a928-1e363450e3aa"
class="components-button components-menu-item__button is-next-40px-default-size"
role="menuitem"
type="button"
>
<span
@@ -9,15 +11,23 @@
<span
class="components-menu-item__info-wrapper"
>
<span
class="components-menu-item__item"
+ id="menu-item-label-cd947a26-61c7-4240-a928-1e363450e3aa"
>
My item
</span>
<span
+ aria-hidden="true"
class="components-menu-item__info"
+ >
+ Extended description of My Item
+ </span>
+ <span
+ class="screen-reader-text"
+ id="menu-item-description-aeea3f06-6823-443c-8f7b-3a763318db23"
>
Extended description of My Item
</span>
</span>
</span>
at Object.toMatchSnapshot (/home/runner/work/gutenberg/gutenberg/packages/components/src/menu-item/test/index.js:62:44)
at Promise.then.completed (/home/runner/work/gutenberg/gutenberg/node_modules/jest-circus/build/utils.js:300:28)
at new Promise (<anonymous>)
at callAsyncCircusFn (/home/runner/work/gutenberg/gutenberg/node_modules/jest-circus/build/utils.js:233:10)
at _callCircusTest (/home/runner/work/gutenberg/gutenberg/node_modules/jest-circus/build/run.js:315:40)
at processTicksAndRejections (node:internal/process/task_queues:105:5)
at _runTest (/home/runner/work/gutenberg/gutenberg/node_modules/jest-circus/build/run.js:251:3)
at _runTestsForDescribeBlock (/home/runner/work/gutenberg/gutenberg/node_modules/jest-circus/build/run.js:125:9)
at _runTestsForDescribeBlock (/home/runner/work/gutenberg/gutenberg/node_modules/jest-circus/build/run.js:120:9)
at run (/home/runner/work/gutenberg/gutenberg/node_modules/jest-circus/build/run.js:70:3)
at runAndTransformResultsToJestFormat (/home/runner/work/gutenberg/gutenberg/node_modules/jest-circus/build/legacy-code-todo-rewrite/jestAdapterInit.js:122:21)
at jestAdapter (/home/runner/work/gutenberg/gutenberg/node_modules/jest-circus/build/legacy-code-todo-rewrite/jestAdapter.js:79:19)
at runTestInternal (/home/runner/work/gutenberg/gutenberg/node_modules/jest-runner/build/runTest.js:367:16)
at runTest (/home/runner/work/gutenberg/gutenberg/node_modules/jest-runner/build/runTest.js:444:34)
at Object.worker (/home/runner/work/gutenberg/gutenberg/node_modules/jest-runner/build/testWorker.js:106:12)
|
|
JavaScript (Node.js 22) 4/4
Process completed with exit code 1.
|
|
JavaScript (Node.js 20) 4/4:
packages/components/src/menu-item/test/index.js#L62
Error: expect(received).toMatchSnapshot()
Snapshot name: `MenuItem should match snapshot when info is provided 1`
- Snapshot - 0
+ Received + 10
@@ -1,6 +1,8 @@
<button
+ aria-describedby="menu-item-description-c27d82b9-5e87-4ff1-8e47-cbfcc4134669"
+ aria-labelledby="menu-item-label-0ac8fcaa-1ac0-4af9-b507-33054368c5db"
class="components-button components-menu-item__button is-next-40px-default-size"
role="menuitem"
type="button"
>
<span
@@ -9,15 +11,23 @@
<span
class="components-menu-item__info-wrapper"
>
<span
class="components-menu-item__item"
+ id="menu-item-label-0ac8fcaa-1ac0-4af9-b507-33054368c5db"
>
My item
</span>
<span
+ aria-hidden="true"
class="components-menu-item__info"
+ >
+ Extended description of My Item
+ </span>
+ <span
+ class="screen-reader-text"
+ id="menu-item-description-c27d82b9-5e87-4ff1-8e47-cbfcc4134669"
>
Extended description of My Item
</span>
</span>
</span>
at Object.toMatchSnapshot (/home/runner/work/gutenberg/gutenberg/packages/components/src/menu-item/test/index.js:62:44)
at Promise.then.completed (/home/runner/work/gutenberg/gutenberg/node_modules/jest-circus/build/utils.js:300:28)
at new Promise (<anonymous>)
at callAsyncCircusFn (/home/runner/work/gutenberg/gutenberg/node_modules/jest-circus/build/utils.js:233:10)
at _callCircusTest (/home/runner/work/gutenberg/gutenberg/node_modules/jest-circus/build/run.js:315:40)
at processTicksAndRejections (node:internal/process/task_queues:95:5)
at _runTest (/home/runner/work/gutenberg/gutenberg/node_modules/jest-circus/build/run.js:251:3)
at _runTestsForDescribeBlock (/home/runner/work/gutenberg/gutenberg/node_modules/jest-circus/build/run.js:125:9)
at _runTestsForDescribeBlock (/home/runner/work/gutenberg/gutenberg/node_modules/jest-circus/build/run.js:120:9)
at run (/home/runner/work/gutenberg/gutenberg/node_modules/jest-circus/build/run.js:70:3)
at runAndTransformResultsToJestFormat (/home/runner/work/gutenberg/gutenberg/node_modules/jest-circus/build/legacy-code-todo-rewrite/jestAdapterInit.js:122:21)
at jestAdapter (/home/runner/work/gutenberg/gutenberg/node_modules/jest-circus/build/legacy-code-todo-rewrite/jestAdapter.js:79:19)
at runTestInternal (/home/runner/work/gutenberg/gutenberg/node_modules/jest-runner/build/runTest.js:367:16)
at runTest (/home/runner/work/gutenberg/gutenberg/node_modules/jest-runner/build/runTest.js:444:34)
at Object.worker (/home/runner/work/gutenberg/gutenberg/node_modules/jest-runner/build/testWorker.js:106:12)
|
|
JavaScript (Node.js 20) 4/4
Process completed with exit code 1.
|
|
JavaScript Date Tests (Node.js 20)
Both node-version and node-version-file inputs are specified, only node-version will be used
|
|
JavaScript Date Tests (Node.js 22)
Both node-version and node-version-file inputs are specified, only node-version will be used
|
|
JavaScript (Node.js 22) 3/4
Both node-version and node-version-file inputs are specified, only node-version will be used
|
|
JavaScript (Node.js 22) 4/4
Both node-version and node-version-file inputs are specified, only node-version will be used
|
|
JavaScript (Node.js 22) 2/4
Both node-version and node-version-file inputs are specified, only node-version will be used
|
|
JavaScript (Node.js 20) 3/4
Both node-version and node-version-file inputs are specified, only node-version will be used
|
|
JavaScript (Node.js 20) 2/4
Both node-version and node-version-file inputs are specified, only node-version will be used
|
|
JavaScript (Node.js 22) 1/4
Both node-version and node-version-file inputs are specified, only node-version will be used
|
|
JavaScript (Node.js 20) 4/4
Both node-version and node-version-file inputs are specified, only node-version will be used
|
|
JavaScript (Node.js 20) 1/4
Both node-version and node-version-file inputs are specified, only node-version will be used
|
Artifacts
Produced during runtime
| Name | Size | |
|---|---|---|
|
build-assets
|
14.1 MB |
|