Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Polish plugin sidebar buttons #755

Open
wants to merge 1 commit into
base: trunk
Choose a base branch
from
Open

Polish plugin sidebar buttons #755

wants to merge 1 commit into from

Conversation

t-hamano
Copy link
Contributor

@t-hamano t-hamano commented Jan 6, 2025

This PR makes the following changes to the plugin sidebar:

  • Align all icons and text: Not all icons are 24px. Some icons are approximately 21px in size instead of 24px in size. Text start positions are not aligned.
  • Invert chevron icons when in RTL languages
  • Remove custom styles for the Help button: I personally think the custom color and top margin are unnecessary.

Screenshorts

Before Afterr
before_ltr after_ltr

RTL language

Before Afterr
rtl_before rtl_after

t-hamano
t-hamano commented Jan 6, 2025
View reviewed changes
src/plugin-sidebar.js
@@ -58,6 +58,23 @@ import AboutPlugin from './editor-sidebar/about';
import ResetTheme from './editor-sidebar/reset-theme';
import './plugin-styles.scss';

function PluginSidebarItem( { icon, path, children, ...props } ) {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I created a common component whose behavior changes depending on whether its items are navigable or not.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@t-hamano