Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

theme json boilerplate fix to ensure fontSizes are saved back to the theme #749

Open
wants to merge 3 commits into
base: trunk
Choose a base branch
from
Open

theme json boilerplate fix to ensure fontSizes are saved back to the theme #749

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6b19d6c
theme json boilerplace fix to ensure fontsizes are saved back the theme
eirichmond Nov 27, 2024
df4eb69
further php sniffer fixes
eirichmond Dec 2, 2024
3deea1e
Merge branch 'trunk' into trunk
eirichmond Dec 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 23 additions & 0 deletions includes/create-theme/resolver_additions.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,6 +79,10 @@ public static function export_theme_data( $content, $extra_theme_data = null ) {

$data = $theme->get_data();

// move Font size preset settings from 'default' to 'theme' to ensure
// any changes made via Global Styles are saved back to the theme
$data = static::font_size_preset_changes( $data );

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the initial function to start the check and change the $data variable

// Add the schema.
if ( empty( $schema ) ) {
global $wp_version;
Expand Down Expand Up @@ -106,6 +110,25 @@ public static function get_user_data() {
: parent::get_user_data();
}

/**
* This checks if the fontSizes has been set and saved to the database.
* If it has then the $data variable is changed and will later be used to save back the theme.
* A method is used from the parent class if it exists to get any user changed settings.
*
* @param array $data
* @return array $data
*/
public static function font_size_preset_changes( $data ) {
$user_data = parent::get_user_data();
if ( method_exists( $user_data, 'get_settings' ) ) {
$user_data = $user_data->get_settings();
if ( isset( $user_data['typography']['fontSizes'] ) && ! empty( $user_data['typography']['fontSizes'] ) ) {
$data['settings']['typography']['defaultFontSizes'] = false;
$data['settings']['typography']['fontSizes'] = $user_data['typography']['fontSizes']['default'];
}
}
return $data;
}
/**
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the function that gets and user data and then uses the parent class method if it exists to access data that is private, then checks if fontSizes is set then appends the settings needs to write to the theme.json file.

* Stringify the array data.
*
Expand Down
Loading
Loading