Implement requests pool #502
Conversation
atosz33
force-pushed
the
requests-pooling
branch
from
8994c31 to
f7ee105
Compare
Implemented requests pool handling, as requests_multiple can't handle pooling.
atosz33
force-pushed
the
requests-pooling
branch
2 times, most recently
from
f7e8cda to
54e4921
Compare
|
Hi, Is there any news on this project? |
|
@jrfnl what's the next step? May I ask to merge this feature into the library? |
|
@andras-tim @atosz33 Thank you both for your interest in and willingness to contribute to Requests. For your information: This repo has had little maintenance over the past few years and had build up quite some technical debt. We're currently working on some structural changes - largely outlined in #460 - to improve the basic setup and remove/diminish some of the technical debt to make the library more easily maintainable for the future. Once those initial changes have been made, we'll start doing (public) triage sessions, going through the open issues and open PRs (also outlined in #460). This ticket will be looked at during those sessions and I'd very much would like to invite you to join these sessions. As for the specific changes in this ticket: I can see the changes are accompanied by tests, but the tests do not (yet) fully cover the change, which can also be seen in the codecov patch report. Making sure that the tests are comprehensive enough to fully cover the change will help get this PR merged more quickly. Hope this helps clarify where we are at this moment. |
|
Dear @jrfnl, Thank you for the detailed information. Of course, I'm open to some round of any kind of sessions - if I can help. 🙂 We are using your lib for years - besides that, many thanks - and now we had a sprint there this pool-based parallel behavior was missed. Therefore @atosz33 has forked, implemented, and pushed back the change. So, the team where I'm working will try to spend time on this PR but I will be glad if the merging process will not take months. Thank you for your work again. |
|
Hiya! We're currently planning two triage sessions for Requests 2.0 and would like to invite you to join us in one or both of these sessions to talk us through the PR and discuss it. The triage sessions are currently planned for:
Would you be available to join us during those times on one of those days ? |
Dear @jrfnl, |
|
@andras-tim Wishing you a good national holiday and I look forward to talking with on Sept 3rd. Got a preference for a time within the above mentioned time slot ? |
Thanks! |
|
@andras-tim Thanks for making the time. 8:00 UTC will be fine. I look forward to speaking with you this Friday! |
|
Here's the link to tomorrow's video call: https://us02web.zoom.us/j/87276335771?pwd=dFNXbjVxcWtuM213TUlVejMvQzVXdz09 Looking forward to it! |
|
FYI: link to tomorrow's triage session if you want to continue the conversation: https://us02web.zoom.us/j/85765782668?pwd=Z1IrUFFaR2lhZFIvcDhCeGJrc1JHdz09 |
Wordpress/Requests currently lacking of requests pool, which instead of multiple requests, use a max size of simultaneous requests in one shot (pool_size), but allows more requests to handle.