Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace osc-ruby with fast_osc #13

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

dermusikman
Copy link
Contributor

I believe fast_osc was written specifically for Sonic Pi, and is now the OSC library in Sonic Pi. It's significantly faster than ruby-osc, and is a drop-in replacement.

@Widdershin
Copy link
Owner

Thanks for the pull request. fast_osc looks much faster!

My only concern is that it's a native extension, and building native extensions requires a compiler toolchain with the correct dev packages installed. I ran into an error attempting to compile it on my system (which I'm sure I could overcome with a few package installs).

I'm concerned this might make installation more difficult for beginners, and also I'm not sure about portability on Windows.

Do you know if there's a way we can fallback on a pure ruby osc library if the native extension compilation fails?

@dermusikman
Copy link
Contributor Author

That's a good point... while I think a script may be able to do some meta-magic, I don't know that the gemspec would allow it.

I would think that if Sonic Pi is working, fast_osc should be available on the system, but I don't know how Ruby works in a Windows environment. (Admittedly, sometimes Ruby gets unnecessarily complicated in a Linux environment!)

I'll try to look into some of these points and let you know.

@davidair
Copy link
Collaborator

davidair commented Sep 7, 2017

I could test on Windows if you'd like

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants