Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use local-web-server package for all servers #473

Open
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

camillobruni
Copy link
Contributor

@camillobruni camillobruni commented Jan 22, 2025

  • Merge the test, dev and npm run server commands to use local-web-server.
  • Send COEP headers by default
  • Run npm ci to regenerate package-lock and sort package.json entries
  • Resolve committed merge conflict in bundled news-site workload

Copy link

netlify bot commented Jan 22, 2025

Deploy Preview for webkit-speedometer ready!

Name Link
🔨 Latest commit 711ec69
🔍 Latest deploy log https://app.netlify.com/sites/webkit-speedometer/deploys/6798d6ac759da2000843e370
😎 Deploy Preview https://deploy-preview-473--webkit-speedometer.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@camillobruni camillobruni requested a review from julienw January 23, 2025 13:55
Copy link
Contributor

@julienw julienw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks pretty good to me!
Here are some suggestions, tell me what you think!

tests/server.mjs Show resolved Hide resolved
tests/server.mjs Outdated Show resolved Hide resolved
Comment on lines +18 to +19
"dev": "node tests/server.mjs",
"server": "node tests/server.mjs",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we need to keep both?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(I would keep just "dev")

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah yeah, wanted to ask... I'd just keep server as an alias. but no strong opinion here.

package.json Outdated Show resolved Hide resolved
@julienw
Copy link
Contributor

julienw commented Jan 24, 2025

Looks like the CI failed too

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants