Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto run unittests in tests/index.html #468

Merged
merged 3 commits into from
Jan 6, 2025

Conversation

camillobruni
Copy link
Contributor

Instead of triggering the tests from the outside, we can always directly start the mocha runner in tests/index.html.
The selenium driver now syncs on either globalThis.testResults being there or the test-complete event.

This way we should be able to reliably run the tests both via selenium and the browser.

Copy link
Contributor

@flashdesignory flashdesignory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@rniwa rniwa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems ok.

@camillobruni camillobruni merged commit a169b1d into WebKit:main Jan 6, 2025
4 checks passed
@camillobruni camillobruni deleted the 2024-12-23_fix_runner branch January 6, 2025 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants