Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix navigation for Firefox #353

Merged
merged 1 commit into from
Jan 25, 2024

Conversation

camillobruni
Copy link
Contributor

Temporarily set the #home hash before clearing it to ensure proper visibility of the home section.

@camillobruni camillobruni requested a review from bgrins January 24, 2024 20:18
@camillobruni camillobruni added the trivial change A change that doesn't affect benchmark results label Jan 24, 2024
Copy link
Member

@rniwa rniwa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a bit funky bug ok.

@bgrins
Copy link
Contributor

bgrins commented Jan 24, 2024

Thanks for figuring out a workaround - we'll separately try to narrow down a reduced test case & fix whatever is happening Firefox. @julienw can you take a look at this PR?

@bgrins bgrins requested review from julienw and removed request for bgrins January 24, 2024 23:02
@camillobruni
Copy link
Contributor Author

Might be worth having a look at the CSS selector again, maybe something is up with that:

section:target,
body:not(body:has(section:target)) #home {
    display: block;
}

@camillobruni camillobruni merged commit 3d93f17 into WebKit:main Jan 25, 2024
4 checks passed
@camillobruni camillobruni deleted the 2024-01-24_fix_hash branch January 25, 2024 09:21
@camillobruni
Copy link
Contributor Author

ups, this accidentally triggered recursive location updates... fix on the way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
trivial change A change that doesn't affect benchmark results v3-blocker
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants