-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement end2end tests #11
Merged
kmiller68
merged 14 commits into
WebKit:main
from
camillobruni:2024-11-26_github_actions
Jan 24, 2025
Merged
Changes from 11 commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
b3ed18e
adding
camillobruni 36c7b48
Merge remote-tracking branch 'webkit/main' into 2024-11-26_github_act…
camillobruni a55964e
more
camillobruni d1c46f2
cleanup
camillobruni d2ed65b
updates
camillobruni 5cd8bb1
adding test
camillobruni 56b1dd4
cleanup
camillobruni a4a42ba
cleanup
camillobruni c33f40a
pre-format
camillobruni a7d0253
newline
camillobruni 8add658
Merge branch 'main' of github.com:camillobruni/JetStream into 2024-11…
camillobruni 0ddf224
wip
camillobruni 6918b99
fixing server and using local-web-server
camillobruni 50af620
minor startDelay fix
camillobruni File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,34 @@ | ||
name: CI | ||
|
||
on: | ||
push: | ||
branches: ["main"] | ||
pull_request: | ||
branches: ["main"] | ||
|
||
# Allows you to run this workflow manually from the Actions tab | ||
workflow_dispatch: | ||
|
||
jobs: | ||
build: | ||
name: Build | ||
runs-on: macos-latest | ||
strategy: | ||
matrix: | ||
browser: [chrome, firefox, safari] | ||
steps: | ||
- name: Install Firefox | ||
if: ${{ matrix.browser == 'firefox' }} | ||
run: brew install --cask firefox | ||
- name: Checkout Branch | ||
uses: actions/checkout@v3 | ||
- name: Setup Node | ||
uses: actions/setup-node@v3 | ||
with: | ||
node-version: 18.13.0 | ||
- name: Install | ||
run: npm install | ||
- name: Run tests | ||
run: | | ||
echo "Running in $BROWSER" | ||
npm run test:${{ matrix.browser }} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,6 @@ | ||
.DS_Store | ||
.directory | ||
/node_modules | ||
|
||
# Ignore auto-generated files by VS & VSCode. | ||
/.vs/ | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems like it will always set
startDelay
toundefined
when the there's nostartDelay
URL parameter. I think that's fine fortestIterationCount
andtestWorstCaseCount
since they'd always be undefined on the web as it is. Although maybe it's worth changing there too so folks aren't surprised?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I hoped to make the initialization explicit by the lines above
globalThis.startDelay ??= undefined;
at least for me that's a bit more consistent across all configuration params.Medium term I'd like to adapt the Params object from Speedometer (this also allows us to easily copy over the ?developerMode UI).
Maybe I missed your point here, but when running via the shell we now also always initialize startDelay=undefined.
With the html runner we'd initialize to undefined by default (and set it again to undefined if there is no matching url param)
But generally not feeling strongly about this one :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the issue is when you do
index.html?report=true
startDelay
ends up asundefined
rather than4000
. If you moved the report check below this and changed it toif (shouldReport) globalThis.startDelay ??= 4000
I think that would fix it.Safari, at least, relies on the startDelay to make sure the browser has calmed down after launching enough to prevent noise.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok, then I understood correctly.
Keeping the old behavior with
report=true
sg.