Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Bikeshed fixup to properly balance section elements #1866

Merged
merged 1 commit into from
Jan 24, 2025
Merged

Conversation

dschuff
Copy link
Member

@dschuff dschuff commented Jan 24, 2025

This regex removes all the leading content up to the div containing the "Introduction" heading, but this content includes an opening <section> tag that wraps all of the front matter. The updated version of Bikeshed is throwing errors because of the unbalanced closing tag.
Fix this by adding the opening tag back.

@dschuff dschuff requested review from rossberg and tlively January 24, 2025 00:21
Copy link
Member

@rossberg rossberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect, thanks!

@Ms2ger Ms2ger merged commit 38b5bdd into main Jan 24, 2025
7 of 8 checks passed
@Ms2ger Ms2ger deleted the fix-section branch January 24, 2025 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants