Enable Linux compatibility with dependency changes and improved dev tooling #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @MikeLippincott ! After making some changes here based on your comment I believe this is now ready to merge. |
jenna-tomkinson
pushed a commit
to jenna-tomkinson/nViz
that referenced
this pull request
Feb 14, 2025
…ooling (WayScience#17) * run linux tests on dev branch * don't show if headless * install qt deps * try async setting * Update run-tests.yml * try additional qt libs * troubleshoot further with docker * linting * Update run-tests.yml * Update run-tests.yml * Update run-tests.yml * Update uv.lock * fallback to napari[all] and setup qt for ubuntu * move to macos-14 for tests * add python3-pyqt5 installation * attempt to install different qt deps * Update run-tests.yml * attempt another linux dep step * update for linting step * update docs
jenna-tomkinson
added a commit
that referenced
this pull request
Feb 14, 2025
* update labels parameter to include default * [pre-commit.ci lite] apply automatic fixes * Enable Linux compatibility with dependency changes and improved dev tooling (#17) * run linux tests on dev branch * don't show if headless * install qt deps * try async setting * Update run-tests.yml * try additional qt libs * troubleshoot further with docker * linting * Update run-tests.yml * Update run-tests.yml * Update run-tests.yml * Update uv.lock * fallback to napari[all] and setup qt for ubuntu * move to macos-14 for tests * add python3-pyqt5 installation * attempt to install different qt deps * Update run-tests.yml * attempt another linux dep step * update for linting step * update docs * [pre-commit.ci lite] apply automatic fixes * fix conflict i hope * [pre-commit.ci lite] apply automatic fixes --------- Co-authored-by: pre-commit-ci-lite[bot] <117423508+pre-commit-ci-lite[bot]@users.noreply.github.com> Co-authored-by: Dave Bunten <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR enables Linux compatibility by making some dependency changes and adding some development tooling intended to help troubleshoot or use nviz within Linux environments through Docker. Mainly this addresses #8. This may also effectively sidestep issues related to #14 (needs verification with Linux GUI).
This PR also bumps the version of MacOS for GH Actions to remain up to date (we were using an outdated and non-ARM based image).
Closes #8
References #14
What kind of change(s) are included?
Checklist
Please ensure that all boxes are checked before indicating that this pull request is ready for review.